Skip to content

Allow Symfony 7 #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2023
Merged

Allow Symfony 7 #1409

merged 2 commits into from
May 30, 2023

Conversation

nicolas-grekas
Copy link
Contributor

No description provided.

This was referenced May 25, 2023
Merged
Closed
@nicolas-grekas
Copy link
Contributor Author

@jderusse @Nyholm or any other maintainer, could you please have a look at this PR? It's on the critical path to unlock the CI to prepare Symfony 7 🙏

@jderusse
Copy link
Member

@jderusse @Nyholm or any other maintainer, could you please have a look at this PR? It's on the critical path to unlock the CI to prepare Symfony 7 pray

Would be great to fix the deprecations (ie, replace assertCount(0, $fooBar) by assertEmpty($fooBar) or assertCount(0, [...$fooBar]))

Nyholm
Nyholm approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the deprecation warnings from PHPUnit?

@jderusse
Copy link
Member

Isn't the deprecation warnings from PHPUnit?

It's triggered by PhpUnit because of our code:

When we call self::assertCount(0, $result->getStackEvents()) here

aws/src/Service/CloudFormation/tests/Integration/CloudFormationClientTest.php

Line 48 in 11379d8

self::assertCount(0, $result->getStackEvents());

The method $result->getStackEvents() is a generator https://github.com/async-aws/aws/blob/11379d8d430fe0f938e9832f092b329aa966cfa1/src/Service/CloudFormation/src/Result/DescribeStackEventsOutput.php#LL52C14-L52C14
Which is no more allowed https://github.com/sebastianbergmann/phpunit/blob/46739478930289fa955fe4697688bae921a2674a/src/Framework/Assert.php#L236-L238

@nicolas-grekas
Copy link
Contributor Author

Deprecations fixed, CI green.

@jderusse jderusse merged commit 8c4c5b0 into async-aws:master May 30, 2023
@jderusse
Copy link
Member

thanks ❤️

nicolas-grekas added a commit to symfony/symfony that referenced this pull request May 30, 2023
@nicolas-grekas
minor #50407 [7.0] Remove hacks that made the CI green (nicolas-grekas)
c574955 
This PR was merged into the 7.0 branch.

Discussion
----------

[7.0] Remove hacks that made the CI green

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follows #50404

The Windows build is blocked by ext-redis and ext-apcu not being available as DLL for PHP 8.2. /cc `@weltling` 🙏

It's time to allow Symfony 7 again :)

- [x] composer/composer#11474
- [x] async-aws/aws#1409
- [x] doctrine/orm#10724
- [x] [FriendsOfPHP/proxy-manager-lts](FriendsOfPHP/proxy-manager-lts@d93bd79)
- [x] symfony/security-acl#111
- [x] tijsverkoyen/CssToInlineStyles#243

We also need a sigchild-enabled PHP, which `@derrabus` knows how to build :)

Commits
-------

6dd126a [7.0] Remove hacks that made the CI green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @jderusse @Nyholm